Replace ByteString #4119
Merged
Replace ByteString #4119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4119 +/- ##
==========================================
- Coverage 91.24% 91.24% -0.01%
==========================================
Files 338 338
Lines 10919 10918 -1
==========================================
- Hits 9963 9962 -1
Misses 956 956 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abmantis
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
typing.ByteStringandcollections.abc.ByteStringwill be removed in Python3.14.AFAICT the actual data type is
bytesanyway, so just use that instead.The alternative would be the full type
bytes | bytearray | memoryview.Originally added in #3644 by @abmantis.
https://docs.python.org/3.13/library/typing.html#typing.ByteString
Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black